Re: [PATCH] mfd: max77620: Fix FPS switch statements
From: Alexandre Courbot
Date: Wed Jun 15 2016 - 02:11:51 EST
On Wed, Jun 15, 2016 at 1:50 AM, Rhyland Klein <rklein@xxxxxxxxxx> wrote:
> On 6/7/2016 4:05 AM, Lee Jones wrote:
>> On Thu, 12 May 2016, Rhyland Klein wrote:
>>
>>> When configuring FPS during probe, assuming a DT node is present for
>>> FPS, the code can run into a problem with the switch statements in
>>> max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
>>> in the case of chip->chip_id == MAX77620, it will set
>>> fps_[mix|max]_period but then fall through to the default switch case
>>> and return -EINVAL. Returning this from max77620_config_fps() will
>>> cause probe to fail.
>>>
>>> Signed-off-by: Rhyland Klein <rklein@xxxxxxxxxx>
>>> ---
>>> drivers/mfd/max77620.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>
>> Applied to -fixes with Thierry and Laxman's Acks.
>>
>
> I don't see this in linux-next yet (as of 20160614). Can we get this
> merged there to.
Was about to say the same thing. FWIW:
Tested-by: Alexandre Courbot <acourbot@xxxxxxxxxx>