Aw: [Cocci] [PATCH v3 3/6] scripts: add glimpse.sh for indexing the kernel

From: SF Markus Elfring
Date: Wed Jun 15 2016 - 06:27:37 EST


> Glimpse is a tool you can use to index the kernel.
> The tool was recently open sourced under the ISC license
> and can be obtained at:

Do you find any official announcement for this software evolution?

Is the wording "recent" really appropriate if you would eventually like to refer to a repository which was published in the year 2014?
https://github.com/gvelez17/glimpse/


Is it nice to mention the script addition also directly in the commit message?


> +DIR=$(dirname $(readlink -f $0))
> +DIR="${DIR}/../"

I would prefer that these variable assignments will be merged into one.

+DIR="$(dirname $(readlink -f $0))/../"

Regards,
Markus