Re: [PATCH] mailbox: pcc: Add PCC request and free channel declarations

[Prakash, Prashanth]

Hi Hoan,

On 6/14/2016 5:12 PM, Hoan Tran wrote:
> As PCC will be used by other clients not only CPPC.
> This change exports pcc_mbox_request_channel() and pcc_mbox_free_channel()
> declarations
>
> Signed-off-by: Hoan Tran <hotran@xxxxxxx>
> ---
>  include/acpi/cppc_acpi.h       | 4 ----
>  include/linux/mailbox_client.h | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/acpi/cppc_acpi.h b/include/acpi/cppc_acpi.h
> index dad8af3..819b4b9 100644
> --- a/include/acpi/cppc_acpi.h
> +++ b/include/acpi/cppc_acpi.h
> @@ -130,8 +130,4 @@ extern int cppc_set_perf(int cpu, struct cppc_perf_ctrls *perf_ctrls);
>  extern int cppc_get_perf_caps(int cpu, struct cppc_perf_caps *caps);
>  extern int acpi_get_psd_map(struct cpudata **);
>  
> -/* Methods to interact with the PCC mailbox controller. */
> -extern struct mbox_chan *
> -	pcc_mbox_request_channel(struct mbox_client *, unsigned int);
> -
>  #endif /* _CPPC_ACPI_H*/
> diff --git a/include/linux/mailbox_client.h b/include/linux/mailbox_client.h
> index 41e2af8..2758d18 100644
> --- a/include/linux/mailbox_client.h
> +++ b/include/linux/mailbox_client.h
> @@ -50,4 +50,8 @@ void mbox_client_txdone(struct mbox_chan *chan, int r); /* atomic */
>  bool mbox_client_peek_data(struct mbox_chan *chan); /* atomic */
>  void mbox_free_channel(struct mbox_chan *chan); /* may sleep */
>  
> +/* Methods to interact with the PCC mailbox controller. */
> +struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *, int);
> +void pcc_mbox_free_channel(struct mbox_chan *chan);
> +
Since these APIs are specific to PCC, may be we should introduce a new header for pcc clients
instead of adding to the common mailbox_client header.
>  #endif /* __MAILBOX_CLIENT_H */

Thanks,
Prashanth