Re: [PATCH 12/13] x86/mm/64: Enable vmapped stacks

From: Andy Lutomirski
Date: Thu Jun 16 2016 - 01:34:19 EST


On Jun 15, 2016 9:32 PM, "Mika PenttilÃ" <mika.penttila@xxxxxxxxxxxx> wrote:
>
> Hi,
>

> > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
> > index 5643fd0b1a7d..fbf036ae72ac 100644
> > --- a/arch/x86/mm/tlb.c
> > +++ b/arch/x86/mm/tlb.c
> > @@ -77,10 +77,25 @@ void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next,
> > unsigned cpu = smp_processor_id();
> >
> > if (likely(prev != next)) {
> > + if (IS_ENABLED(CONFIG_VMAP_STACK)) {
> > + /*
> > + * If our current stack is in vmalloc space and isn't
> > + * mapped in the new pgd, we'll double-fault. Forcibly
> > + * map it.
> > + */
> > + unsigned int stack_pgd_index =
> > + pgd_index(current_stack_pointer());
>
>
> stack pointer is still the previous task's, current_stack_pointer() returns that, not
> next task's which was intention I guess. Things may happen to work if on same pgd, but at least the
> boot cpu init_task_struct is special.

This is intentional. When switching processes, we first switch the mm
and then switch the task. We need to make sure that the prev stack is
mapped in the new mm or we'll double-fault and die after switching the
mm which still trying to execute on the old stack.

The change to switch_to makes sure that the new stack is mapped.

--Andy