Re: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening

From: Joe Perches
Date: Thu Jun 16 2016 - 02:04:28 EST


On Wed, 2016-06-15 at 13:58 -0700, Joe Perches wrote:
> There is code duplication of a masked ethernet address comparison here
> so make it a separate function instead.
>
> Miscellanea:
>
> o Neaten alignment of FWINV macro uses to make it clearer for the reader
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
>
> This masked_ether_addr_equal function could go into etherdevice.h,
> but I don't see another use like it in kernel code.  Is there one?

Turns out there are at least a few more uses in bridge/netfilter

 net/bridge/netfilter/ebt_arp.c
 net/bridge/netfilter/ebtables.c

Maybe this?
---