Re: [PATCH] libnvdimm: use devm_add_action_or_reset()

From: Johannes Thumshirn
Date: Thu Jun 16 2016 - 03:34:32 EST


On Wed, Jun 15, 2016 at 04:31:55PM -0700, Dan Williams wrote:
> Clean up needless calls to the action routine by letting
> devm_add_action_or_reset() call it automatically. This does cause the
> disk to registered and immediately unregistered when a memory allocation
> fails, but the block layer should be prepared for such an event.
>
> Reported-by: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>

Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850