Re: net: stmmac: dwmac-rk: fixes for Wake-on-Lan on RK3288

[Giuseppe CAVALLARO]

Hi Vincent

On 6/15/2016 7:04 PM, Vincent Palatin wrote:
> On Sun, Jun 12, 2016 at 11:46 PM, Giuseppe CAVALLARO
> <peppe.cavallaro@xxxxxx> wrote:
> > On 6/11/2016 3:00 AM, Vincent Palatin wrote:
> > > In order to support Wake-On-Lan when using the RK3288 integrated MAC
> > > (with an external RGMII PHY), we need to avoid shutting down the regulator
> > > of the external PHY when the MAC is suspended as it's currently done in
> > > the MAC
> > > platform code.
> > > As a first step, create independant callbacks for suspend/resume rather
> > > than
> > > re-using exit/init callbacks. So the dwmac platform driver can behave
> > > differently
> > > on suspend where it might skip shutting the PHY and at module unloading.
> > > Then update the dwmac-rk driver to switch off the PHY regulator only if we
> > > are
> > > not planning to wake up from the LAN.
> > > Finally add the PMT interrupt to the MAC device tree configuration, so we
> > > can
> > > wake up the core from it when the PHY has received the magic packet.
> >
> >
> > IMO these could be sent for net-next and also other glue logic
> > files should be reworked in order to use the new API for coherence.
>
> Given they will have the same set of functions for exit/init and
> suspend/resume, you mean duplicating the callbacks like this :
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c
> @@ -359,6 +359,8 @@ static int sti_dwmac_probe(struct platform_device *pdev)
>         plat_dat->bsp_priv = dwmac;
>         plat_dat->init = sti_dwmac_init;
>         plat_dat->exit = sti_dwmac_exit;
> +       plat_dat->suspend = sti_dwmac_exit;
> +       plat_dat->resume = sti_dwmac_init;
>         plat_dat->fix_mac_speed = data->fix_retime_src;
>
>         ret = sti_dwmac_init(pdev, plat_dat->bsp_priv);
>
> Is this anyhow useful ?

I think this is mandatory otherwise you are not guaranteeing the PM
stuff working on the rest of the glue-logics (not only sti); because
init/exit calls won't be called anymore. So I kindly ask you to
propagate the fix and send the V3.  The implementation above is ok for
me.

peppe