Re: [PATCH RFC 0/3] perf script: Add callindent option

From: Arnaldo Carvalho de Melo
Date: Thu Jun 16 2016 - 12:37:57 EST


Em Thu, Jun 16, 2016 at 03:34:31PM +0300, Adrian Hunter escreveu:
> Hi
>
> Andi Kleen sent a couple of patches to add a callindent option to
> perf script. If Andi is agreeable, I would like to propose an
> alternative implementation.

Andi?

- Arnaldo

> While there are some differences in the resulting output, the main
> differences are:
>
> 1. Tell the decoder to feed branches to the thread stack, which has the
> advantage that it happens before branch filtering and so can be used
> with different itrace options (e.g. it still works when only showing
> calls, even though the thread stack needs to see calls and returns). Also
> it does not conflict with using the thread stack to get callchains.
>
> 2. Print "call" or "ret" instead of using a different event
>
>
> Adrian Hunter (3):
> perf: script: Fix documentation of '-f' when it should be '-F'
> perf auxtrace: Add option to feed branches to the thread stack
> perf script: Add callindent option
>
> tools/perf/Documentation/perf-script.txt | 26 +++++++-----
> tools/perf/builtin-script.c | 70 ++++++++++++++++++++++++++++++++
> tools/perf/util/auxtrace.h | 2 +
> tools/perf/util/intel-bts.c | 22 +++++++---
> tools/perf/util/intel-pt.c | 5 ++-
> tools/perf/util/thread-stack.c | 7 ++++
> tools/perf/util/thread-stack.h | 1 +
> 7 files changed, 117 insertions(+), 16 deletions(-)
>
>
> Regards
> Adrian