Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()
From: Andreas Schwab
Date: Thu Jun 16 2016 - 15:18:24 EST
- Next message: Andy Lutomirski: "Re: [PATCH 04/13] mm: Track NR_KERNEL_STACK in pages instead of number of stacks"
- Previous message: Grant Likely: "Re: [PATCH 0/6] Intel Integrated Sensor Hub Support (ISH)"
- In reply to: Peter Zijlstra: "Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()"
- Next in thread: Geert Uytterhoeven: "Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Peter Zijlstra <peterz@xxxxxxxxxxxxx> writes:
> On Thu, Jun 16, 2016 at 05:04:24PM +0200, Andreas Schwab wrote:
>> Peter Zijlstra <peterz@xxxxxxxxxxxxx> writes:
>>
>> > If not, do you want me to 'fix' this or just remove the comment?
>>
>> It's not broken, so nothing to fix.
>
> Its non obvious code, that's usually plenty reason to change it.
You appear to be the only one who has a problem with that documented
construct.
Andreas.
--
Andreas Schwab, schwab@xxxxxxxxxxxxxx
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
- Next message: Andy Lutomirski: "Re: [PATCH 04/13] mm: Track NR_KERNEL_STACK in pages instead of number of stacks"
- Previous message: Grant Likely: "Re: [PATCH 0/6] Intel Integrated Sensor Hub Support (ISH)"
- In reply to: Peter Zijlstra: "Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()"
- Next in thread: Geert Uytterhoeven: "Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]