Re: [PATCH v6 3/5] tpm: Factor out reading of timeout and duration capabilities

From: Jarkko Sakkinen
Date: Thu Jun 16 2016 - 16:20:59 EST


On Fri, Jun 10, 2016 at 06:55:05PM -0700, Ed Swierk wrote:
> Factor sending the TPM_GetCapability command and validating the result
> from tpm_get_timeouts() into a new function. Return all errors to the
> caller rather than swallowing them (e.g. when tpm_transmit_cmd()
> returns nonzero).

LGTM but I have to test this on next week. I'll give final
Reviewed/Tested-by after that. Thanks for the good work.

> Signed-off-by: Ed Swierk <eswierk@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/char/tpm/tpm-interface.c | 96 ++++++++++++++++++++++------------------
> 1 file changed, 52 insertions(+), 44 deletions(-)

/Jarkko