Re: [PATCH v9 09/22] IB/hns: Add hca support

[Wei Hu (Xavier)]

On 2016/6/9 15:10, Leon Romanovsky wrote:
> On Wed, Jun 01, 2016 at 11:37:51PM +0800, Lijun Ou wrote:
> > This patch mainly setup hca for RoCE. It will do a series of
> > initial works, as follows:
> >      1. init uar table, allocate uar resource
> >      2. init pd table
> >      3. init cq table
> >      4. init mr table
> >      5. init qp table
> >
> > Signed-off-by: Wei Hu <xavier.huwei@xxxxxxxxxx>
> > Signed-off-by: Nenglong Zhao <zhaonenglong@xxxxxxxxxxxxx>
> > Signed-off-by: Lijun Ou <oulijun@xxxxxxxxxx>
> > ---
> <...>
>
> > +
> > +	ret = hns_roce_bitmap_init(&cq_table->bitmap, hr_dev->caps.num_cqs,
> > +				   hr_dev->caps.num_cqs - 1,
> > +				   hr_dev->caps.reserved_cqs, 0);
> > +	if (ret)
> > +		return ret;
> > +
> > +	return 0;
> You can return directly ret, instead last 4 lines.
Hi, leon
    We have fixed it.
    And Oulijun have sent PATCH V10. Thanks

Regards
Wei Hu
> > +}
> > +