Re: [PATCH v3] Doc/memory-barriers: Add Korean translation
From: Minchan Kim
Date: Fri Jun 17 2016 - 02:25:14 EST
On Wed, Jun 15, 2016 at 03:47:34PM +0900, SeongJae Park wrote:
> 2016-06-09 5:45 GMT+09:00 SeongJae Park <sj38.park@xxxxxxxxx>:
> > 2016-06-09 2:24 GMT+09:00 Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>:
> >> On Wed, Jun 08, 2016 at 05:58:41PM +0900, SeongJae Park wrote:
> >>> This commit adds Korean version of memory-barriers.txt document. The
> >>> header is refered to HOWTO Korean version.
> >>>
> >>> The translator, SeongJae Park, is interested in parallel programming and
> >>> translating[1] a book[2] about the topic.
> >>>
> >>> The translation has started from Feb, 2016 and using a github public
> >>> repository[3] to maintain the work. The work is following[4] updates to
> >>> the original document as well.
> >>>
> >>> Because the translator has knowledge about the topic and already
> >>> following up the upstream changes, one would sure that this translation
> >>> will keep reasonable quality and freshness.
> >>>
> >>> [1] https://git.kernel.org/cgit/linux/kernel/git/paulmck/perfbook.git/commit/FAQ.txt?id=edbfcdee0460
> >>> [2] https://www.kernel.org/pub/linux/kernel/people/paulmck/perfbook/perfbook.html
> >>> [3] https://github.com/sjp38/linux.doc_trans_membarrier
> >>> [4] https://github.com/sjp38/linux.doc_trans_membarrier/commit/06bd12d390f164fd253b861fc3aa8006d6d19ed9
> >>>
> >>> Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx>
> >>> Acked-by: David Howells <dhowells@xxxxxxxxxx>
> >>> Signed-off-by: Parl E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> >>> Acked-by: Minchan Kim <minchan@xxxxxxxxxx>
> >>
> >> I cannot judge this, so I must defer to Minchan. That said, the diffstat
> >> since your version of April 18 is as follows:
> >>
> >> memory-barriers.txt | 303 ++++++++++++++++++++++++++++++----------------------
> >> 1 file changed, 175 insertions(+), 128 deletions(-)
> >>
> >> I cannot tell which mainline version these patches correspond to, but the
> >> English version has this diffstat since v4.5:
> >>
> >> memory-barriers.txt | 293 +++++++++++++++++++++++++++++++++++++++++-----------
> >> 1 file changed, 234 insertions(+), 59 deletions(-)
> >>
> >> So your level of change thus far seems plausible.
> >
> > I agree that Minchan deserves to judge that since he is the Korean translations
> > maintainer.
>
> Minchan, may I ask your opinion about this patch?
Sorry for late response.
I think it's really worth. That's why I support it. However, until now,
I didn't review it in detail. Sorry about that and stuck with urgent
works so I asked colleague byungchul who scheduler guy, he has an
interest so He will review this patch soon.
Hope it helps you.
Thanks.