Re: [PATCH V2 33/63] clocksource/drivers/time-armada-370-xp: Convert init function to return error

[Daniel Lezcano]

On 06/17/2016 09:21 AM, Jon Hunter wrote:
> On 16/06/16 22:26, Daniel Lezcano wrote:
> > The init functions do not return any error. They behave as the following:
> >
> >    - panic, thus leading to a kernel crash while another timer may work and
> >         make the system boot up correctly
> >
> >    or
> >
> >    - print an error and let the caller unaware if the state of the system
> >
> > Change that by converting the init functions to return an error conforming
> > to the CLOCKSOURCE_OF_RET prototype.
> >
> > Proper error handling (rollback, errno value) will be changed later case
> > by case, thus this change just return back an error or success in the init
> > function.
> >
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> > ---
> >   drivers/clocksource/tegra20_timer.c | 28 ++++++++++++++++------------
> >   1 file changed, 16 insertions(+), 12 deletions(-)
>
> The $subject does not appear to match with the driver you are modifying
> here.

Ah, crap. I introduced a shift somewhere in the patchset. Fixed.

Thanks !

  -- Daniel


--
 <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog