Re: [PATCH] mm/compaction: remove local variable is_lru

[Vlastimil Babka]

On 06/17/2016 11:50 AM, Michal Hocko wrote:
> On Fri 17-06-16 17:32:51, Ganesh Mahendran wrote:
> > local varialbe is_lru was used for tracking non-lru pages(such as
> > balloon pages).
> >
> > But commit
> > 112ea7b668d3 ("mm: migrate: support non-lru movable page migration")
>
> this commit sha is not stable because it is from the linux-next tree.
>
> > introduced a common framework for non-lru page migration and moved
> > the compound pages check before non-lru movable pages check.
> >
> > So there is no need to use local variable is_lru.
> >
> > Signed-off-by: Ganesh Mahendran <opensource.ganesh@xxxxxxxxx>
>
> Other than that the patch looks ok and maybe it would be worth folding
> into the mm-migrate-support-non-lru-movable-page-migration.patch

Agreed.