Re: [PATCH V2 45/63] clocksource/drivers/timer-keystone: Convert init function to return error

[Santosh Shilimkar]

On 6/16/2016 2:27 PM, Daniel Lezcano wrote:
> The init functions do not return any error. They behave as the following:
>
>   - panic, thus leading to a kernel crash while another timer may work and
>        make the system boot up correctly
>
>   or
>
>   - print an error and let the caller unaware if the state of the system
>
> Change that by converting the init functions to return an error conforming
> to the CLOCKSOURCE_OF_RET prototype.
>
> Proper error handling (rollback, errno value) will be changed later case
> by case, thus this change just return back an error or success in the init
> function.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> ---
>  drivers/clocksource/timer-keystone.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
Acked-by: Santosh Shilimkar <ssantosh@xxxxxxxxxx>