Re: [PATCH 1/6] Documentation: hid: Intel ISH HID document

[Jiri Kosina]

On Sat, 11 Jun 2016, Srinivas Pandruvada wrote:

> Document explaining ISH HID operation and implementation.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> ---
>  Documentation/hid/intel-ish-hid.txt | 417 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 417 insertions(+)
>  create mode 100644 Documentation/hid/intel-ish-hid.txt
> 
> diff --git a/Documentation/hid/intel-ish-hid.txt b/Documentation/hid/intel-ish-hid.txt
> new file mode 100644
> index 0000000..2de0ab5
> --- /dev/null
> +++ b/Documentation/hid/intel-ish-hid.txt
> @@ -0,0 +1,417 @@
> +Intel Integrated Sensor Hub (ISH)
> +===============================
> +
> +A sensor hub enables the ability to offload sensor polling and algorithm
> +processing to a dedicated low power co-processor. This allows the core
> +processor to go into low power modes more often, resulting in the increased
> +battery life.
[ ... snip ... ]

What I would like to see added here is a bit more of a higher-level 
overview of the implementation.

It's a *lot* of new code. I am still trying to make my way through it. One 
thing that I am currently trying to figure out, and which, if documented, 
would be much easier to review, would be: my current understanding is that 
this is both transport (ll) driver and a kind-of a bus at the same time.

Could yo please put some more comprehensive overview of the overall 
architecture into the documentation?

Thanks,

-- 
Jiri Kosina
SUSE Labs