Re: [PATCH 5/5] regulator: qcom_rpm-regulator: Add support for pm8018 rpm regulator

From: Mark Brown
Date: Sat Jun 18 2016 - 06:09:51 EST


On Fri, Jun 17, 2016 at 09:53:52AM -0700, Bjorn Andersson wrote:
> On Fri 17 Jun 03:22 PDT 2016, Neil Armstrong wrote:

> > + { "dig_corner", QCOM_RPM_VOLTAGE_CORNER, &pm8018_corner,
> > + "vdd_dig_corner" },
> > +
> > + { }
> > +};

> We have discussed the corners for a long time and I think we've
> concluded that they should be exposed as something like an OPP. What we
> have agreed on is that they should not be exposed as a regulator with
> voltages 1-4uV.

Oops, missed this - yes, that needs to go as it's definitely a complete
abuse of the API.

Attachment: signature.asc
Description: PGP signature