Re: [PATCH 0/7] asus-wireless: LED control

From: Corentin Chary
Date: Sun Jun 19 2016 - 03:19:11 EST


On Mon, Jun 13, 2016 at 10:57 PM, JoÃo Paulo Rechi Vita
<jprvita@xxxxxxxxx> wrote:
> This series adds support for controlling the airplane-mode indicator LED
> present in some Asus laptops. It also creates a quirk in asus-wmi so it does not
> create RFKill devices for platforms that use asus-wireless and where there is a
> competition for the LED control (see "asus-wmi: Create quirk for airplane_mode
> LED" for more details).
>
> JoÃo Paulo Rechi Vita (7):
> asus-wireless: Toggle airplane mode LED
> asus-wmi: Create quirk for airplane_mode LED
> asus-wmi: Add quirk_no_rfkill for the Asus N552VW
> asus-wmi: Add quirk_no_rfkill for the Asus U303LB
> asus-wmi: Add quirk_no_rfkill for the Asus Z550MA
> asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UF
> asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UA
>
> drivers/platform/x86/Kconfig | 2 +
> drivers/platform/x86/asus-nb-wmi.c | 49 ++++++++++++++++++-
> drivers/platform/x86/asus-wireless.c | 91 +++++++++++++++++++++++++++++++++++-
> drivers/platform/x86/asus-wmi.c | 8 ++--
> drivers/platform/x86/asus-wmi.h | 1 +
> 5 files changed, 145 insertions(+), 6 deletions(-)
>
> --
> 2.5.0
>

Looks good to me. I hope that we can get rid of all these quirks in
the near future.

Reviewed-by: Corentin Chary <corentin.chary@xxxxxxxxx>

--
Corentin Chary
http://xf.iksaif.net