Re: [PATCH 2/3] staging: luster: Checkpatch Cleanup

From: Craig Inches
Date: Sun Jun 19 2016 - 15:53:24 EST


I did build the kernel 1 for each change, then a final with all changes
applied.

Apologies if I missed something,

Craig

On Sat, Jun 18, 2016 at 07:02:35PM -0700, Greg Kroah-Hartman wrote:
> On Sat, Jun 18, 2016 at 10:25:55PM +0100, Craig Inches wrote:
> > Macros with complex values should be enclosed in parenthesis
> >
> > Signed-off-by: Craig Inches <craig@xxxxxxxxxxxxxxx>
> > ---
> > drivers/staging/lustre/lustre/include/cl_object.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> ALWAYS test build your patches, to not do so just makes maintainers
> grumpy...
>
> Remember, checkpatch is a _hint_, it's not always right.
>
> greg k-h