Re: [PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module

[Sjoerd Simons]

Hey,

On Tue, 2016-06-14 at 17:20 -0400, Javier Martinez Canillas wrote:
> The driver is for a trackpad device so is not needed for booting and
> makes more sense to have it as module to reduce the kernel image
> size.
> 
> It was probably enabled as built-in because module autoload was not
> working when the I2C device was registered by OF but this got fixed
> in commit b7d21058b40b ("Input: atmel_mxt_ts - add maxtouch to I2C
> table for module autoload") so it's safe to enable as a module now.
> 
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Make sense to me,
Reviewed-by: Sjoerd Simons <sjoerd.simons@xxxxxxxxxxxxxxx>
> ---
> 
> Âarch/arm/configs/multi_v7_defconfig | 2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig
> b/arch/arm/configs/multi_v7_defconfig
> index ee7c884ab5d8..c29bdd070721 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -269,7 +269,7 @@ CONFIG_MOUSE_PS2_ELANTECH=y
> ÂCONFIG_MOUSE_CYAPA=m
> ÂCONFIG_MOUSE_ELAN_I2C=y
> ÂCONFIG_INPUT_TOUCHSCREEN=y
> -CONFIG_TOUCHSCREEN_ATMEL_MXT=y
> +CONFIG_TOUCHSCREEN_ATMEL_MXT=m
> ÂCONFIG_TOUCHSCREEN_MMS114=m
> ÂCONFIG_TOUCHSCREEN_ST1232=m
> ÂCONFIG_TOUCHSCREEN_STMPE=y

-- 

Sjoerd Simons
Collabora Ltd.