Re: [PATCH V2 08/63] clocksource/drivers/st_lpc: Convert init function to return error

From: Maxime Coquelin
Date: Mon Jun 20 2016 - 08:12:06 EST




On 06/16/2016 11:26 PM, Daniel Lezcano wrote:
The init functions do not return any error. They behave as the following:

- panic, thus leading to a kernel crash while another timer may work and
make the system boot up correctly

or

- print an error and let the caller unaware if the state of the system

Change that by converting the init functions to return an error conforming
to the CLOCKSOURCE_OF_RET prototype.

Proper error handling (rollback, errno value) will be changed later case
by case, thus this change just return back an error or success in the init
function.

Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
---
drivers/clocksource/clksrc_st_lpc.c | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)

Acked-by: Maxime Coquelin <maxime.coquelin@xxxxxx>

Thanks!
Maxime