Re: [PATCH V2 12/63] clocksource/drivers/armv7m_systick: Convert init function to return error

From: Maxime Coquelin
Date: Mon Jun 20 2016 - 08:28:31 EST


2016-06-16 23:26 GMT+02:00 Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>:
> The init functions do not return any error. They behave as the following:
>
> - panic, thus leading to a kernel crash while another timer may work and
> make the system boot up correctly
>
> or
>
> - print an error and let the caller unaware if the state of the system
>
> Change that by converting the init functions to return an error conforming
> to the CLOCKSOURCE_OF_RET prototype.
>
> Proper error handling (rollback, errno value) will be changed later case
> by case, thus this change just return back an error or success in the init
> function.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> ---
> drivers/clocksource/armv7m_systick.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)

Acked-by: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>

Thanks!
Maxime