Re: [PATCH] mtip32xx: Remove deprecated create_workqueue

From: Tejun Heo
Date: Mon Jun 20 2016 - 11:02:53 EST


On Sat, Jun 18, 2016 at 01:52:05PM +0530, Bhaktipriya Shridhar wrote:
> alloc_workqueue replaces deprecated create_workqueue().
>
> A dedicated workqueue has been used since the workqueue isr_workq is
> involved in irq handling path of block driver and requires forward
> progress under memory pressure. Hence, WQ_MEM_RECLAIM has been set.
> Since there are only a fixed number of work items, explicit concurrency
> limit is unnecessary here.
>
> flush_workqueue is unnecessary since destroy_workqueue() itself calls
> drain_workqueue() which flushes repeatedly till the workqueue
> becomes empty. Hence the calls to flush_workqueue() before
> destroy_workqueue() have been dropped.

Looks good.

Thanks!

--
tejun