Re: [PATCH v2 0/3] firmware: scpi: add device power domain support

[Sudeep Holla]

On 20/06/16 18:56, Kevin Hilman wrote:
> Sudeep Holla <sudeep.holla@xxxxxxx> writes:
>
> > This series add support for SCPI based device device power state
> > management using genpd.
> >
> > Regards,
> > Sudeep
> >
> > v1[1]->v2:
> > 	- Fixed the endianness handling in scpi_device_get_power_state
> > 	  as spotted by Tixy
> > 	- Renamed scpi_pd.c to scpi_pm_domain.c as suggested by Ulf
> > 	- Added Mark's ack on DT binding
> >
> > [1] https://marc.info/?l=linux-kernel&m=146522850003483&w=2
> >
> > Sudeep Holla (3):
> >    firmware: arm_scpi: add support for device power state management
> >    Documentation: add DT bindings for ARM SCPI power domains
> >    firmware: scpi: add device power domain support using genpd
>
> Other than the couple nits on specific patches,
>
> Reviewed-by: Kevin Hilman <khilman@xxxxxxxxxxxx>
>
> And just a[nother] reminder to be sure to keep things that are Juno
> specific well described since we know other vendors will be (and are
> being) "creative" in their implementations of SCPI.

Agreed as mentioned in the other thread.

I just sent a PR to arm-soc this afternoon. Do you think it's better to
recall it and incorporate this ?

Extremely sorry for rushing, I thought it would get too late. Ulf
reviewed them so I rushed a bit.

--
Regards,
Sudeep