Re: [v4] powerpc: spinlock: Fix spin_unlock_wait()
From: Michael Ellerman
Date: Mon Jun 20 2016 - 20:41:09 EST
On Fri, 2016-10-06 at 03:51:28 UTC, Boqun Feng wrote:
> There is an ordering issue with spin_unlock_wait() on powerpc, because
> the spin_lock primitive is an ACQUIRE and an ACQUIRE is only ordering
> the load part of the operation with memory operations following it.
...
>
> Suggested-by: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Boqun Feng <boqun.feng@xxxxxxxxx>
> Reviewed-by: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
> [mpe: Inline the "nop" ll/sc loop and set EH=0, munge change log]
> Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/6262db7c088bbfc26480d10144
cheers