Re: [PATCH V3 2/4] clk: Combine DT binding doc for max77686 and max77802

[Laxman Dewangan]

On Monday 20 June 2016 10:09 PM, Rob Herring wrote:
> On Fri, Jun 17, 2016 at 04:21:05PM +0530, Laxman Dewangan wrote:
> > The clock IP used on the Maxim PMICs max77686 and max77802 are
> > same. The configuration of clock register is also same except
> > the number of clocks.
> >
> > Define the common DT binding file for the clocks of Maxim PMICs
> > MAX77686 and MAX77802. For this, remove the separate DT binding
> > document file for maxim,max77802 and move all information to
> > maxim,max77686 DT binding document.
> >
> > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> > CC: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> > CC: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> > Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> >
> > ---
> > Changes from V1:
> > - Rewrite description to remvoe ref to driver.
> > - Taken care of comment from Krzysztof on the supported clocks and
> >    DT bindings.
> >
> > Changes from V2:
> > - Collected RBs.
> > ---
> >   .../devicetree/bindings/clock/maxim,max77686.txt   | 82 ++++++++++++++++------
> >   .../devicetree/bindings/clock/maxim,max77802.txt   | 44 ------------
> >   2 files changed, 59 insertions(+), 67 deletions(-)
> >   delete mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt
> >
> > diff --git a/Documentation/devicetree/bindings/clock/maxim,max77686.txt b/Documentation/devicetree/bindings/clock/maxim,max77686.txt
> > index 9c40739..4d973b5 100644
> > --- a/Documentation/devicetree/bindings/clock/maxim,max77686.txt
> > +++ b/Documentation/devicetree/bindings/clock/maxim,max77686.txt
> > @@ -1,11 +1,15 @@
> > -Binding for Maxim MAX77686 32k clock generator block
> > +Binding for Maxim MAX77686/MAX77802 32k clock generator block
> >   
> > -This is a part of device tree bindings of MAX77686 multi-function device.
> > -More information can be found in bindings/mfd/max77686.txt file.
> > +This is a part of device tree bindings of MAX77686/MAX77802 multi-function
> > +device. More information can be found in bindings/mfd/max77686.txt file for
> > +MAX77686 and bindings/mfd/max77802.txt for MAX77802.
> >   
> >   The MAX77686 contains three 32.768khz clock outputs that can be controlled
> >   (gated/ungated) over I2C.
> >   
> > +The MAX77802 contains two 32.768khz clock outputs that can be controlled
> > +(gated/ungated) over I2C.
> > +
> >   Following properties should be presend in main device node of the MFD chip.
> >   
> >   Required properties:
> I'd expect to see compatible strings updated...

There is no separate compatible string for clock. The clock nodes is the 
parent node only and the compatible described in the parent DT binding doc.


Do we also need to add same thing here?