Re: [PATCH] irqchip: fix the config HISILICON_IRQ_MBIGEN dependency error.

[Marc Zyngier]

On 21/06/16 10:26, Jiancheng Xue wrote:
> This patch fixes the compiling error caused when
> config HISILICON_IRQ_MBIGEN is selected but
> PCI_MSI is not seleted.
> 
> Signed-off-by: Jiancheng Xue <xuejiancheng@xxxxxxxxxxxxx>
> ---
>  drivers/irqchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index fa33c50..23dcf3e 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -110,7 +110,7 @@ config DW_APB_ICTL
>  config HISILICON_IRQ_MBIGEN
>  	bool
>  	select ARM_GIC_V3
> -	select ARM_GIC_V3_ITS
> +	select ARM_GIC_V3_ITS if PCI_MSI
>  	select GENERIC_MSI_IRQ_DOMAIN

How can this be correct? The MBIGEN uses platform MSI (not PCI) and
relies on the ITS (it doesn't work without it). It seems that you're
papering over another issue.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...