Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

[Felipe Balbi]

Hi,

Tony Lindgren <tony@xxxxxxxxxxx> writes:
> * Felipe Balbi <balbi@xxxxxxxxxx> [160621 03:06]:
>> 8<----------------------------------------------------------------------
>> 	vbus = read(VBUS_STATE); /* could be a gpio_get_value() */
>>         id = read(ID_STATE); /* could be a gpio_get_value() */
>> 
>>         set_role(id);
>>         set_vbus(vbus);
>
> We should use regulator framework API for set_vbus() because of
> the delays involved bringing it up. And we already have separate
> PHY and charger chips where VBUS is provided by the charger chip.

yeah, no arguments there.

-- 
balbi

Attachment: signature.asc
Description: PGP signature