Re: [PATCH] include: net: cfg802154: rename ieee802154_llsec_device.hwaddr to extended_addr

From: kbuild test robot
Date: Tue Jun 21 2016 - 07:31:39 EST

Hi,

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.7-rc4 next-20160621]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Thomas-Rowland/include-net-cfg802154-rename-ieee802154_llsec_device-hwaddr-to-extended_addr/20160621-182617
config: x86_64-rhel (attached as .config)
compiler: gcc-4.9 (Debian 4.9.3-14) 4.9.3
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All errors (new ones prefixed by >>):

net/ieee802154/nl-mac.c: In function 'llsec_parse_dev':
>> net/ieee802154/nl-mac.c:1003:5: error: 'struct ieee802154_llsec_device' has no member named 'hwaddr'
dev->hwaddr = nla_get_hwaddr(info->attrs[IEEE802154_ATTR_HW_ADDR]);
^
net/ieee802154/nl-mac.c: In function 'ieee802154_nl_fill_dev':
>> net/ieee802154/nl-mac.c:1069:55: error: 'const struct ieee802154_llsec_device' has no member named 'hwaddr'
nla_put_hwaddr(msg, IEEE802154_ATTR_HW_ADDR, desc->hwaddr,
^
net/ieee802154/nl-mac.c: In function 'llsec_iter_devkeys':
net/ieee802154/nl-mac.c:1208:17: error: 'struct ieee802154_llsec_device' has no member named 'hwaddr'
dpos->hwaddr, kpos,
^

vim +1003 net/ieee802154/nl-mac.c

3e9c156e Phoebe Buckheister 2014-05-16 997 dev->pan_id = nla_get_shortaddr(info->attrs[IEEE802154_ATTR_PAN_ID]);
3e9c156e Phoebe Buckheister 2014-05-16 998 dev->short_addr = nla_get_shortaddr(info->attrs[IEEE802154_ATTR_SHORT_ADDR]);
3e9c156e Phoebe Buckheister 2014-05-16 999 } else {
3e9c156e Phoebe Buckheister 2014-05-16 1000 dev->short_addr = cpu_to_le16(IEEE802154_ADDR_UNDEF);
3e9c156e Phoebe Buckheister 2014-05-16 1001 }
3e9c156e Phoebe Buckheister 2014-05-16 1002
3e9c156e Phoebe Buckheister 2014-05-16 @1003 dev->hwaddr = nla_get_hwaddr(info->attrs[IEEE802154_ATTR_HW_ADDR]);
3e9c156e Phoebe Buckheister 2014-05-16 1004 dev->frame_counter = nla_get_u32(info->attrs[IEEE802154_ATTR_LLSEC_FRAME_COUNTER]);
3e9c156e Phoebe Buckheister 2014-05-16 1005 dev->seclevel_exempt = !!nla_get_u8(info->attrs[IEEE802154_ATTR_LLSEC_DEV_OVERRIDE]);
3e9c156e Phoebe Buckheister 2014-05-16 1006 dev->key_mode = nla_get_u8(info->attrs[IEEE802154_ATTR_LLSEC_DEV_KEY_MODE]);
3e9c156e Phoebe Buckheister 2014-05-16 1007
3e9c156e Phoebe Buckheister 2014-05-16 1008 if (dev->key_mode >= __IEEE802154_LLSEC_DEVKEY_MAX)
3e9c156e Phoebe Buckheister 2014-05-16 1009 return -EINVAL;
3e9c156e Phoebe Buckheister 2014-05-16 1010
3e9c156e Phoebe Buckheister 2014-05-16 1011 return 0;
3e9c156e Phoebe Buckheister 2014-05-16 1012 }
3e9c156e Phoebe Buckheister 2014-05-16 1013
3e9c156e Phoebe Buckheister 2014-05-16 1014 static int llsec_add_dev(struct net_device *dev, struct genl_info *info)
3e9c156e Phoebe Buckheister 2014-05-16 1015 {
3e9c156e Phoebe Buckheister 2014-05-16 1016 struct ieee802154_mlme_ops *ops = ieee802154_mlme_ops(dev);
3e9c156e Phoebe Buckheister 2014-05-16 1017 struct ieee802154_llsec_device desc;
3e9c156e Phoebe Buckheister 2014-05-16 1018
3e9c156e Phoebe Buckheister 2014-05-16 1019 if (llsec_parse_dev(info, &desc))
3e9c156e Phoebe Buckheister 2014-05-16 1020 return -EINVAL;
3e9c156e Phoebe Buckheister 2014-05-16 1021
3e9c156e Phoebe Buckheister 2014-05-16 1022 return ops->llsec->add_dev(dev, &desc);
3e9c156e Phoebe Buckheister 2014-05-16 1023 }
3e9c156e Phoebe Buckheister 2014-05-16 1024
3e9c156e Phoebe Buckheister 2014-05-16 1025 int ieee802154_llsec_add_dev(struct sk_buff *skb, struct genl_info *info)
3e9c156e Phoebe Buckheister 2014-05-16 1026 {
3e9c156e Phoebe Buckheister 2014-05-16 1027 if ((info->nlhdr->nlmsg_flags & (NLM_F_CREATE | NLM_F_EXCL)) !=
3e9c156e Phoebe Buckheister 2014-05-16 1028 (NLM_F_CREATE | NLM_F_EXCL))
3e9c156e Phoebe Buckheister 2014-05-16 1029 return -EINVAL;
3e9c156e Phoebe Buckheister 2014-05-16 1030
3e9c156e Phoebe Buckheister 2014-05-16 1031 return ieee802154_nl_llsec_change(skb, info, llsec_add_dev);
3e9c156e Phoebe Buckheister 2014-05-16 1032 }
3e9c156e Phoebe Buckheister 2014-05-16 1033
3e9c156e Phoebe Buckheister 2014-05-16 1034 static int llsec_del_dev(struct net_device *dev, struct genl_info *info)
3e9c156e Phoebe Buckheister 2014-05-16 1035 {
3e9c156e Phoebe Buckheister 2014-05-16 1036 struct ieee802154_mlme_ops *ops = ieee802154_mlme_ops(dev);
3e9c156e Phoebe Buckheister 2014-05-16 1037 __le64 devaddr;
3e9c156e Phoebe Buckheister 2014-05-16 1038
3e9c156e Phoebe Buckheister 2014-05-16 1039 if (!info->attrs[IEEE802154_ATTR_HW_ADDR])
3e9c156e Phoebe Buckheister 2014-05-16 1040 return -EINVAL;
3e9c156e Phoebe Buckheister 2014-05-16 1041
3e9c156e Phoebe Buckheister 2014-05-16 1042 devaddr = nla_get_hwaddr(info->attrs[IEEE802154_ATTR_HW_ADDR]);
3e9c156e Phoebe Buckheister 2014-05-16 1043
3e9c156e Phoebe Buckheister 2014-05-16 1044 return ops->llsec->del_dev(dev, devaddr);
3e9c156e Phoebe Buckheister 2014-05-16 1045 }
3e9c156e Phoebe Buckheister 2014-05-16 1046
3e9c156e Phoebe Buckheister 2014-05-16 1047 int ieee802154_llsec_del_dev(struct sk_buff *skb, struct genl_info *info)
3e9c156e Phoebe Buckheister 2014-05-16 1048 {
3e9c156e Phoebe Buckheister 2014-05-16 1049 return ieee802154_nl_llsec_change(skb, info, llsec_del_dev);
3e9c156e Phoebe Buckheister 2014-05-16 1050 }
3e9c156e Phoebe Buckheister 2014-05-16 1051
3e9c156e Phoebe Buckheister 2014-05-16 1052 static int
3e9c156e Phoebe Buckheister 2014-05-16 1053 ieee802154_nl_fill_dev(struct sk_buff *msg, u32 portid, u32 seq,
3e9c156e Phoebe Buckheister 2014-05-16 1054 const struct ieee802154_llsec_device *desc,
3e9c156e Phoebe Buckheister 2014-05-16 1055 const struct net_device *dev)
3e9c156e Phoebe Buckheister 2014-05-16 1056 {
3e9c156e Phoebe Buckheister 2014-05-16 1057 void *hdr;
3e9c156e Phoebe Buckheister 2014-05-16 1058
3e9c156e Phoebe Buckheister 2014-05-16 1059 hdr = genlmsg_put(msg, 0, seq, &nl802154_family, NLM_F_MULTI,
3e9c156e Phoebe Buckheister 2014-05-16 1060 IEEE802154_LLSEC_LIST_DEV);
3e9c156e Phoebe Buckheister 2014-05-16 1061 if (!hdr)
3e9c156e Phoebe Buckheister 2014-05-16 1062 goto out;
3e9c156e Phoebe Buckheister 2014-05-16 1063
3e9c156e Phoebe Buckheister 2014-05-16 1064 if (nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name) ||
3e9c156e Phoebe Buckheister 2014-05-16 1065 nla_put_u32(msg, IEEE802154_ATTR_DEV_INDEX, dev->ifindex) ||
3e9c156e Phoebe Buckheister 2014-05-16 1066 nla_put_shortaddr(msg, IEEE802154_ATTR_PAN_ID, desc->pan_id) ||
3e9c156e Phoebe Buckheister 2014-05-16 1067 nla_put_shortaddr(msg, IEEE802154_ATTR_SHORT_ADDR,
3e9c156e Phoebe Buckheister 2014-05-16 1068 desc->short_addr) ||
a558da09 Nicolas Dichtel 2016-04-25 @1069 nla_put_hwaddr(msg, IEEE802154_ATTR_HW_ADDR, desc->hwaddr,
a558da09 Nicolas Dichtel 2016-04-25 1070 IEEE802154_ATTR_PAD) ||
3e9c156e Phoebe Buckheister 2014-05-16 1071 nla_put_u32(msg, IEEE802154_ATTR_LLSEC_FRAME_COUNTER,
3e9c156e Phoebe Buckheister 2014-05-16 1072 desc->frame_counter) ||

:::::: The code at line 1003 was first introduced by commit
:::::: 3e9c156e2c210ab67b12b1b692983a6b97c19d3f ieee802154: add netlink interfaces for llsec

:::::: TO: Phoebe Buckheister <phoebe.buckheister@xxxxxxxxxxxxxxxxxx>
:::::: CC: David S. Miller <davem@xxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data