Re: [PATCHv4 4/7] Documentation: dt: socfpga: Add Arria10 Ethernet binding

[Thor Thayer]

On 06/21/2016 10:48 AM, Rob Herring wrote:
> On Tue, Jun 21, 2016 at 9:46 AM, Thor Thayer
> <tthayer@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > Hi Rob,
> >
> >
> > On 06/21/2016 08:33 AM, Rob Herring wrote:
> > > On Mon, Jun 20, 2016 at 09:50:49AM -0500, tthayer@xxxxxxxxxxxxxxxxxxxxx
> > > wrote:
> > > > From: Thor Thayer <tthayer@xxxxxxxxxxxxxxxxxxxxx>
> > > >
> > > > Add the device tree bindings needed to support the Altera Ethernet
> > > > FIFO buffers on the Arria10 chip.
> > > >
> > > > Signed-off-by: Thor Thayer <tthayer@xxxxxxxxxxxxxxxxxxxxx>
> > > > ---
> > > > v2  No Change
> > > > v3  Change to common compatible string based on maintainer comments
> > > >       Add local IRQ values.
> > > > v4  Add compatible string for parent node.
> > > > ---
> > > >    .../bindings/arm/altera/socfpga-eccmgr.txt         |   24
> > > > ++++++++++++++++++++
> > > >    1 file changed, 24 insertions(+)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt
> > > > b/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt
> > > > index 15eb0df..7c714ba 100644
> > > > --- a/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt
> > > > +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt
> > > > @@ -82,6 +82,14 @@ Required Properties:
> > > >    - interrupts : Should be single bit error interrupt, then double bit
> > > > error
> > > >          interrupt, in this order.
> > > >
> > > > +Ethernet FIFO ECC
> > > > +Required Properties:
> > > > +- compatible : Should be "altr,socfpga-eth-mac-ecc"
> > > > +- reg        : Address and size for ECC block registers.
> > > > +- parent     : phandle to parent (altr,socfpga-stmmac) Ethernet node.
> > >
> > >
> > > Sorry if I wasn't clear before, but I was suggesting changing 'parent'
> > > to 'altr,ethernet-mac':
> > >
> > > altr,ethernet-mac = <&gmac0>;
> > >
> > > Rob
> > Ahh, I see what you're saying.
> >
> > I used parent as the tag because I have a generic function for validating
> > that the parent status is "okay" using the "parent" string in my
> > validate_parent_available() function (see below).
>
> Ah, so common ecc-mgr code is parsing it. Then how about 'altr,ecc-parent'?
>
> Rob
That's clean - I'll change to that string. Thanks!