Re: [PATCH v2] scripts/gdb: add constants.py to .gitignore
From: Kieran Bingham
Date: Tue Jun 21 2016 - 17:21:24 EST
On 21/06/16 22:11, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@xxxxxx>
>
> Since scripts/gdb/linux/constants.py is autogenerated, this should have
> been added to .gitignore when it was introduced.
>
> Fixes: f197d75fcad1 ("scripts/gdb: provide linux constants")
> Signed-off-by: Omar Sandoval <osandov@xxxxxx>
> ---
> Thanks, Kieran, I totally missed the comment in top-level .gitignore.
>
> scripts/gdb/linux/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/gdb/linux/.gitignore b/scripts/gdb/linux/.gitignore
> index 52e4e61140d1..d5abd6ce9425 100644
> --- a/scripts/gdb/linux/.gitignore
> +++ b/scripts/gdb/linux/.gitignore
> @@ -1,2 +1,3 @@
> *.pyc
> *.pyo
> +/constants.py
Does this work with '/' at the beginning of the line?
It looks like all the other sub-tree .gitignores don't use a leading /
on their ignores
If you're happy, I'd like to drop the leading '/'.
(I think I can do this silently as I pick the patch if you approve,
rather than send another patch for a one-byte change)
Other than that:
Signed-off-by: Kieran Bingham <kieran@xxxxxxxxxxx>
--
Regards
Kieran Bingham