Re: [PATCH] ASoC: cs53l30: Add MUTE pin control support via GPIO

[Nicolin Chen]

On Tue, Jun 21, 2016 at 04:34:37PM -0500, Rob Herring wrote:
> On Mon, Jun 20, 2016 at 06:54:44PM -0700, Nicolin Chen wrote:
> > The codec chip has a physical MUTE pin to let users control it via
> > GPIO. So this patch add a mute control support to the driver.
> > 
> > Signed-off-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx>
> > ---
> >  .../devicetree/bindings/sound/cs53l30.txt          |  2 ++
> >  sound/soc/codecs/cs53l30.c                         | 30 ++++++++++++++++++++++
> >  sound/soc/codecs/cs53l30.h                         |  1 +
> >  3 files changed, 33 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/cs53l30.txt b/Documentation/devicetree/bindings/sound/cs53l30.txt
> > index 18d6b99..6f7d3c8 100644
> > --- a/Documentation/devicetree/bindings/sound/cs53l30.txt
> > +++ b/Documentation/devicetree/bindings/sound/cs53l30.txt
> > @@ -13,6 +13,8 @@ Optional properties:
> >  
> >    - reset-gpios : a GPIO spec for the reset pin.
> >  
> > +  - mute-gpios : a GPIO spec for the MUTE pin.
> 
> Please define the active state for the gpio.

The active state here is programmable and being taken care by the
driver automatically. Maybe I should have mentioned this in the
binding as well?

Thanks
Nic