Re: [PATCH 1/4] drivers: input: powerkey for HISI 65xx SoC

From: John Stultz
Date: Tue Jun 21 2016 - 20:06:39 EST


On Tue, Jun 14, 2016 at 3:43 PM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
> From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@xxxxxxxxxx>
>
> This driver provides a input driver for the power button on the
> HiSi 65xx SoC for boards like HiKey.
>
> This driver was originally by Zhiliang Xue <xuezhiliang@xxxxxxxxxx>
> then basically rewritten by Jorge, but preserving the original
> module author credits.
>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@xxxxxxxxxx>
> Cc: Feng Chen <puck.chen@xxxxxxxxxxxxx>
> Cc: Wei Xu <xuwei5@xxxxxxxxxxxxx>
> Cc: Guodong Xu <guodong.xu@xxxxxxxxxx>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@xxxxxxxxxx>
> [jstultz: Reworked commit message, folded in other fixes/cleanups
> from Jorge, implemented some larger cleanups suggested by DmitryT]
> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> ---
> v2: Major rework integrating feedback from Dmitry.
> v3: Dropped of_match compatible line since no longer using DT
> for this.
> v4: Removed MODULE_DEVICE_TABLE(of, hi65xx_powerkey_of_match) line
> I missed in the last revision, which casued build issues w/
> modules.

Hey Dmitry,
Just wanted to ping you to see if there was anything else you were
wanting changed with this patch. Lee has queued the mfd patches in
-next, so I wanted to be sure to address any concerns you had that was
keeping this from heading upstream in 4.8 (hopefully :).

thanks
-john