Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF
From: Naveen N. Rao
Date: Wed Jun 22 2016 - 03:07:59 EST
On 2016/06/21 09:04PM, Michael Ellerman wrote:
> On Tue, 2016-06-21 at 12:28 +0530, Naveen N. Rao wrote:
> > On 2016/06/21 09:38AM, Michael Ellerman wrote:
> > > On Sun, 2016-06-19 at 23:06 +0530, Naveen N. Rao wrote:
> > > >
> > > > #include <asm/kprobes.h>
> > > >
> > > > in bpf_jit_comp64.c
> > > >
> > > > Can you please check if it resolves the build error?
> > >
> > > Can you? :D
> >
> > :)
> > Sorry, I should have explained myself better. I did actually try your
> > config and I was able to reproduce the build error. After the above
> > #include, that error went away, but I saw some vdso related errors. I
> > thought I was doing something wrong and needed a different setup for
> > that particular kernel config, which is why I requested your help in the
> > matter. I just didn't do a good job of putting across that message...
>
> Ah OK. Not sure why you're seeing VDSO errors?
'Cause I wasn't paying attention. I tried your .config on a LE machine.
It works fine on BE, as it should.
>
> > Note to self: randconfig builds *and* more time drafting emails :)
>
> No stress. You don't need to do randconfig builds, or even build all the
> arch/powerpc/ configs, just try to do a reasonable set, something like - ppc64,
> powernv, pseries, pmac32, ppc64e.
Ok, will do.
>
> I'm happy to catch the esoteric build failures.
>
> > Do you want me to respin the patches?
>
> No that's fine, I'll fix it up here.
Thanks,
Naveen