Re: [patch V2 00/20] timer: Refactor the timer wheel

From: Mike Galbraith
Date: Wed Jun 22 2016 - 03:37:57 EST


On Fri, 2016-06-17 at 13:26 +0000, Thomas Gleixner wrote:
> This is the second version of the timer wheel rework series. The first series
> can be found here:
>
> http://lkml.kernel.org/r/20160613070440.950649741@xxxxxxxxxxxxx
>
> The series is also available in git:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.timers

FWIW, testing with ltp, I noticed a new failure in logs. It turns out
to be intermittent, but the testcase mostly fails.

rtbox:~ # /usr/local/ltp/conformance/interfaces/sigtimedwait/sigtimedwait_1-1.run-test
Test FAILED: sigtimedwait() did not return in the required time
time_elapsed: 1.197057
...come on, you can do it...
rtbox:~ # /usr/local/ltp/conformance/interfaces/sigtimedwait/sigtimedwait_1-1.run-test
Test PASSED

#define ERRORMARGIN 0.1
...
if ((time_elapsed > SIGTIMEDWAITSEC + ERRORMARGIN)
|| (time_elapsed < SIGTIMEDWAITSEC - ERRORMARGIN)) {
printf("Test FAILED: sigtimedwait() did not return in "
"the required time\n");
printf("time_elapsed: %lf\n", time_elapsed);
return PTS_FAIL;
}

Looks hohum to me, but gripe did arrive with patch set, so you get a note.

-Mike