Re: [RFC] regmap: Add regmap_pipe_read API
From: Crestez Dan Leonard
Date: Wed Jun 22 2016 - 04:34:04 EST
On 06/21/2016 09:42 PM, Mark Brown wrote:
> On Thu, Jun 16, 2016 at 06:24:36PM +0300, Crestez Dan Leonard wrote:
>
>> + val = ((u8*)val) + read_len;
>
> This cast looks broken, you should be able to do pointer arithmetic on
> void pointers as though they were char *.
>
Pointer arithmetic on void* is not standard C, it's a GCC extension. I
know that GCC extensions are allowed for the kernel but is it really
encouraged to rely on them this way?
Anyway, are my concerns about the regmap_bus implementation for SPMI
valid? In theory this could be submitted in it's present form and let
regmap+spmi users
If this API is otherwise fine I can just resend this marked as [PATCH]
with the cast removed and some rearranged comments.
--
Regards,
Leonard