Re: [PATCH v3] cgroup: Disable IRQs while holding css_set_lock
From: Zefan Li
Date: Wed Jun 22 2016 - 21:05:48 EST
On 2016/6/23 4:28, Daniel Bristot de Oliveira wrote:
> While testing the deadline scheduler + cgroup setup I hit this
> warning.
>
...
> The warn is the spin_(lock|unlock)_bh(&css_set_lock) in the interrupt
> context. Converting the spin_lock_bh to spin_lock_irq(save) to avoid
> this problem - and other problems of sharing a spinlock with an
> interrupt.
>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Li Zefan <lizefan@xxxxxxxxxx>
> Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
> Cc: Juri Lelli <juri.lelli@xxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: cgroups@xxxxxxxxxxxxxxx
> Cc: stable@xxxxxxxxxxxxxxx # 4.5+
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Reviewed-by: Rik van Riel <riel@xxxxxxxxxx>
> Reviewed-by: "Luis Claudio R. Goncalves" <lgoncalv@xxxxxxxxxx>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
>
Acked-by: Zefan Li <lizefan@xxxxxxxxxx>