Re: [PATCH 0/5] gpio: refactor of_parse_own_gpio() and of_get_named_gpiod_flags()

[Linus Walleij]

On Tue, Jun 14, 2016 at 12:07 PM, Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:

> But, after reading this code around, I thought it was more complex
> than needed.  So, I decided to clean-up it instead of fix the bug.
>
> Talking about of_parse_own_gpio(), does it need to call gpiochip_find()
> in the first place?
>
> The caller of this function, of_gpiochip_scan_gpios() already knows the
> gpio_chip.  I want to make the implementation more straight-forward.

Thanks a lot for this patch series, it eases maintenance of the gpiolib
OF core a lot, and makes the code size smaller too. I bet it also
gives better speed.

This is a very valuable contribution from you and Socionext to anyone
using GPIO with DT.

Yours,
Linus Walleij