Re: [PATCH V2 0/3] perf script: Add callindent option

[Andi Kleen]

On Thu, Jun 23, 2016 at 04:40:55PM +0300, Adrian Hunter wrote:
> Hi
> 
> Andi Kleen sent a couple of patches to add a callindent option to
> perf script. Andi was agreeable to this alternative implementation.
> 
> While there are some differences in the resulting output, the main
> difference is:
> 
>  1. Tell the decoder to feed branches to the thread stack, which has the
>  advantage that it happens before branch filtering and so can be used
>  with different itrace options (e.g. it still works when only showing
>  calls, even though the thread stack needs to see calls and returns). Also
>  it does not conflict with using the thread stack to get callchains.

Looks all good to me. 

Acked-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Thanks,
-Andi