Re: [PATCH v2 1/3] block: add QUEUE_FLAG_DAX for devices to advertise their DAX support

From: Mike Snitzer
Date: Thu Jun 23 2016 - 17:11:37 EST


On Thu, Jun 23 2016 at 1:36pm -0400,
Kani, Toshimitsu <toshi.kani@xxxxxxx> wrote:

> On Thu, 2016-06-23 at 19:31 +0300, Yigal Korman wrote:
> > On Thu, Jun 23, 2016 at 2:54 AM, Toshi Kani <toshi.kani@xxxxxxx> wrote:
> > >
> > >
> > > Currently, presence of direct_access() in block_device_operations
> > > indicates support of DAX on its block device.  Because
> > > block_device_operations is instantiated with 'const', this DAX
> > > capablity may not be enabled conditinally.
> > >
> > > In preparation for supporting DAX to device-mapper devices, add
> > > QUEUE_FLAG_DAX to request_queue flags to advertise their DAX
> > > support.  This will allow to set the DAX capability based on how
> > > mapped device is composed.
> >
> > Hi Toshi,
> > This patch is very helpful!
> > I think QUEUE_FLAG_DAX can also help with identifying dax devices in
> > userspace.
> > Perhaps you'd be willing to squash the patch below with this one or
> > add it to your submission?
>
> Hi Yigal,
>
> Good idea.  Mike can probably take it into his tree, but I will include it
> into the series if I needed to submit v3.
>
> Acked-by: Toshi Kani <toshi.kani@xxxxxxx>

As you can see I sent out v3 of this set. Jens will need to pick up the
"block:" patches but I'll pick up the DM patches once Jens does so.