Re: [PATCH 3/3] rt-tests: Add cyclicdeadline and deadline_test to the Make system

From: John Kacur
Date: Fri Jun 24 2016 - 07:41:00 EST




On Thu, 23 Jun 2016, Steven Rostedt wrote:

> On Thu, 23 Jun 2016 14:11:51 +0200
> John Kacur <jkacur@xxxxxxxxxx> wrote:
>
>
> > index 9c50456f7419..f530488545e0 100644
> > --- a/src/sched_deadline/cyclicdeadline.c
> > +++ b/src/sched_deadline/cyclicdeadline.c
> > @@ -1,4 +1,6 @@
> > +#ifndef _GNU_SOURCE
> > #define _GNU_SOURCE
> > +#endif
> > #include <pthread.h>
> > #include <stdarg.h>
> > #include <stdlib.h>
> > diff --git a/src/sched_deadline/deadline_test.c b/src/sched_deadline/deadline_test.c
> > index 8a813c494520..2794730febc4 100644
> > --- a/src/sched_deadline/deadline_test.c
> > +++ b/src/sched_deadline/deadline_test.c
> > @@ -29,7 +29,9 @@
> > * Look for "simple_test"
> > *
> > */
> > +#ifndef _GNU_SOURCE
> > #define _GNU_SOURCE
> > +#endif
>
> I'd say nuke these if they are already defined via the Makefile or
> something. I can move the define to the Makefile in my github too.
>
> -- Steve

Agreed.