RE: linux-next: build failure after merge of the crypto tree

From: Benedetto, Salvatore
Date: Fri Jun 24 2016 - 09:37:34 EST




> -----Original Message-----
> From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx]
> Sent: Friday, June 24, 2016 2:33 PM
> To: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Cc: linux-next@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Benedetto,
> Salvatore <salvatore.benedetto@xxxxxxxxx>
> Subject: Re: linux-next: build failure after merge of the crypto tree
>
> On Fri, Jun 24, 2016 at 04:20:22PM +1000, Stephen Rothwell wrote:
> > Hi Herbert,
> >
> > After merging the crypto tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > net/built-in.o: In function `.ecdh_shared_secret':
> > (.text+0x4ad8d0): multiple definition of `.ecdh_shared_secret'
> > crypto/built-in.o:(.text+0x113f0): first defined here
> > net/built-in.o:(.opd+0x430e0): multiple definition of `ecdh_shared_secret'
> > crypto/built-in.o:(.opd+0x1d40): first defined here
> >
> > Caused by commit
> >
> > 3c4b23901a0c ("crypto: ecdh - Add ECDH software support")
> >
> > The other definition is in net/bluetooth/ecc.c
> >
> > I added the following patch for today (probably a better name could be
> > chosen):
>
> I think the intention is that net/bluetooth/ecc.c will be deleted in favour of
> the implementation in crypto. But for now I have applied your patch so we
> can progress. Thanks Stephen.

Thanks Stephen, Herbert.

I already submitted the patch to the Bluetooth subsystem that removes
the net/Bluetooth/ecc.c module

Apologies for the inconvenience.

Regards,
Salvatore