Re: [PATCH] mm/compaction: remove unnecessary order check in try_to_compact_pages()

[Andrew Morton]

On Wed, 15 Jun 2016 14:16:20 +0530 Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx> wrote:

> On 06/15/2016 12:22 PM, Ganesh Mahendran wrote:
> > The caller __alloc_pages_direct_compact() already check (order == 0).
> > So no need to check again.
> 
> Yeah, the caller (__alloc_pages_direct_compact) checks if the order of
> allocation is 0. But we can remove it there and keep it in here as this
> is the actual entry point for direct page compaction.

I think the check in __alloc_pages_direct_compact() is OK - it's a bit
silly to do a (small) bunch of additional work in
__alloc_pages_direct_compact() when orer==0.