Re: [PATCH 1/1] iommu/amd: initialize devid variable before using it

[Wan ZongShun]

2016-06-26 16:33 GMT+08:00 Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>:
> Commit 2a0cb4e2d423 ("iommu/amd: Add new map for storing IVHD dev entry
> type HID") added a call to DUMP_printk in init_iommu_from_acpi() which
> used the value of devid before this variable was initialized.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>
> ---
>  drivers/iommu/amd_iommu_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
> index 9e0034196e10..d091defc3426 100644
> --- a/drivers/iommu/amd_iommu_init.c
> +++ b/drivers/iommu/amd_iommu_init.c
> @@ -1107,13 +1107,13 @@ static int __init init_iommu_from_acpi(struct amd_iommu *iommu,
>                                 break;
>                         }
>
> +                       devid = e->devid;
>                         DUMP_printk("  DEV_ACPI_HID(%s[%s])\t\tdevid: %02x:%02x.%x\n",
>                                     hid, uid,
>                                     PCI_BUS_NUM(devid),
>                                     PCI_SLOT(devid),
>                                     PCI_FUNC(devid));
>
> -                       devid  = e->devid;
>                         flags = e->flags;
>

Sure, thanks for your patch.
This is my fault.

>                         ret = add_acpi_hid_device(hid, uid, &devid, false);
> --
> 2.9.0
>



-- 
---
Vincent Wan(Zongshun)
www.mcuos.com