Re: [PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular

From: Chanwoo Choi
Date: Sun Jun 26 2016 - 22:28:25 EST


Hi Paul,

On 2016ë 06ì 26ì 03:43, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> menuconfig PM_DEVFREQ_EVENT
> bool "DEVFREQ-Event device Support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> This code wasn't using module_init, so we don't need to be concerned
> with altering the initcall level here.
>
> We don't replace module.h with init.h since the file already has that.
> But we do add export.h since this file does export some symbols.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> ---
> drivers/devfreq/devfreq-event.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)

Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

Regards,
Chanwoo Choi