Re: [PATCH] cpufreq: dt: call of_node_put() before error out

From: Viresh Kumar
Date: Mon Jun 27 2016 - 01:52:59 EST


On 27-06-16, 14:50, Masahiro Yamada wrote:
> If of_match_node() fails, this init function bails out without
> calling of_node_put().
>
> I also changed of_node_put(of_root) to of_node_put(np); both of them
> hold the same pointer, but it seems better to call of_node_put()
> against the node returned by of_find_node_by_path().
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
>
> drivers/cpufreq/cpufreq-dt-platdev.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)

Thanks.

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh