Re: [PATCH v10 03/22] IB/hns: Add initial main frame driver and get cfg info

[Leon Romanovsky]

On Sat, Jun 25, 2016 at 06:29:31PM +0800, Wei Hu (Xavier) wrote:
> 
> 
> On 2016/6/24 19:48, Leon Romanovsky wrote:
> >On Thu, Jun 16, 2016 at 10:35:11PM +0800, Lijun Ou wrote:
> >>This patch mainly added the initial bare main driver. It
> >>could get the relative configure information of net node.
> >>
> >>Signed-off-by: Wei Hu <xavier.huwei@xxxxxxxxxx>
> >>Signed-off-by: Nenglong Zhao <zhaonenglong@xxxxxxxxxxxxx>
> >>Signed-off-by: Lijun Ou <oulijun@xxxxxxxxxx>
> >>---

...

> >>+		return -ENOMEM;
> >>+
> >>+	for (i = 0; i < HNS_ROCE_MAX_PORTS; i++) {
> >>+		net_node = of_parse_phandle(np, "eth-handle", i);
> >>+		if (net_node) {
> >>+			pdev = of_find_device_by_node(net_node);
> >>+			netdev = platform_get_drvdata(pdev);
> >>+			phy_port = (u8)i;
> >>+			if (netdev) {
> >>+				hr_dev->iboe.netdevs[port_cnt] = netdev;
> >>+				hr_dev->iboe.phy_port[port_cnt] = phy_port;
> >>+			} else {
> >>+				return -ENODEV;
> >>+			}
> >>+			port_cnt++;
> >>+		}
> >>+	}
> >Do you want to check port_cnt value, before continue?
> Hi, Leon
>     Maybe we need not to check port_cnt value.
>     port_cnt can be ensured smaller than HNS_ROCE_MAX_PORTS.

You can in theory to get port_cnt == 0, in such case it is wise to
return error.

Attachment: signature.asc
Description: Digital signature