Re: [PATCH net-next 6/6] r8152: add byte_enable for ocp_read_word function

From: Sergei Shtylyov
Date: Mon Jun 27 2016 - 06:57:41 EST


Hello.

On 6/27/2016 8:07 AM, Hayes Wang wrote:

Add byte_enable for ocp_read_word() to replace reading 4 bytes data
with reading the desired 2 bytes data.

This is used to avoid the issue which is described in commit:b4d99def.

scripts/checkpatch.pl now enforces certain commit citing style, yours doesn't match.

The origin method always reads 4 bytes data, and it may have problem
when reading the PHY regiters.

Registers.

The new method is supported since RTL8152B, but it doesn't influence
the previous chips. The bits of the byte_enable for the previous chips
are the reserved bits, and the hw would ignore them.

Signed-off-by: Hayes Wang <hayeswang@xxxxxxxxxxx>

[...]

MBR, Sergei