Re: [PATCH] [perf]: update makefile message for installing required libs

From: Arnaldo Carvalho de Melo
Date: Mon Jun 27 2016 - 11:34:48 EST


Em Mon, Jun 27, 2016 at 06:59:57AM -0700, neerajbadlani@xxxxxxxxx escreveu:
> From: Neeraj Badlani <neerajbadlani@xxxxxxxxx>
>
> In case of missing library (libslang), give hint to install library (libslang2-dev)
> Since libslang-dev is not provided by Ubuntu's apt-package
>
> Signed-off-by: Neeraj Badlani <neerajbadlani@xxxxxxxxx>
> ---
> tools/perf/config/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 5ad0255..e57d4d7 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -437,7 +437,7 @@ endif
>
> ifndef NO_SLANG
> ifneq ($(feature-libslang), 1)
> - msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
> + msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev);

Too many 'or', I'll apply it as:

+ msg := $(warning slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev);

Thanks,

- Arnaldo

> NO_SLANG := 1
> else
> # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h
> --
> 2.7.4