Re: [PATCH 1/1] regulator: max77620: check for valid regulator info
From: Mark Brown
Date: Mon Jun 27 2016 - 12:14:22 EST
On Mon, Jun 27, 2016 at 05:13:44PM +0530, Venkat Reddy Talla wrote:
> Check for valid regulator information data before
> configuring FPS source and FPS power up/down
> period to avoid NULL pointer exception if entries for
> PMIC regulators not provided through device tree.
This sounds like it's papering over a bug in the driver - the driver
should be able to instantiate without anything beyond the registration
of the device. What's the driver relying on from the DT?
> SD4 regulator is not supported by MAX77620 PMIC, removing
> SD4 entry from regulator information list.
This appears to be a separate change to the above and should be a
separate patch.
Attachment:
signature.asc
Description: PGP signature